Branches That Don't Suck #4: Pull Request Best Practices
Watch the Video
Or watch it directly on YouTube: Click here
Video Description
There's a big difference between a team that uses pull requests and a team that gets value from pull requests. The difference is in the details: how big are your PRs, how do you write descriptions, how do you review, how fast do you respond. Let's fix your PR workflow.
What you'll learn: • Why some teams hate PRs (and how to fix it) • The two sides of a good PR (author vs reviewer) • Why small PRs are good PRs (under 400 lines) • The "just one more thing" trap • Writing good PR titles and descriptions • PR description template • What reviewers should look for • What reviewers should NOT focus on • Giving helpful feedback (with examples) • Why review turnaround time matters • Handling disagreements constructively • PR anti-patterns to avoid
Key insights: • Large PRs get rubber-stamped, small PRs get real reviews • If you're tempted to write "and" in your title, split the PR • "This is wrong" vs "This will throw if null. Add a check?" • Aim for review within 24 hours • The goal is better code, not being right • Rubber stamp, gatekeeper, perfectionist, ghost - don't be these
This applies whether you're using GitHub, Azure DevOps, GitLab, or any Git-based workflow.
Previous Video: When Branches Are Symptoms Next Video: Branch Protection Rules ► Full Playlist: https://www.youtube.com/playlist?list=PLGxFXI4dC2sgmEG8vl1IoOVTj1y8V6Y6E
PRs finally make sense? Smash that like button! Subscribe - next up we cover branch protection rules! How long do PRs wait for review on your team? Tell me in the comments!
#Git #PullRequests #CodeReview #GitWorkflow #DevOps #GitHub #BestPractices #TeamWork
0:00 Pull Request Best Practices 0:22 Why do some teams hate pull requests? 0:45 The Two Sides of a Good PR 1:38 Small PRs are good PRs. 2:01 What 'Small' Actually Means 2:46 ⚠️ The 'Just One More Thing' Trap 3:31 Writing Good PR Titles 4:01 Writing Good PR Descriptions 4:57 What Reviewers Should Look For 5:40 What Reviewers Should NOT Focus On 6:21 Giving Good Feedback 6:55 Review Turnaround Time Matters 7:28 Handling Disagreements 8:22 PR Anti-Patterns to Avoid 9:06 Quick Recap 9:42 Thanks for Watching
Video Info
- Duration: 9:46
- Published: January 28, 2026
